Add option to match including current container name#186
Open
AlexVallat wants to merge 1 commit intokintesh:masterfrom
Open
Add option to match including current container name#186AlexVallat wants to merge 1 commit intokintesh:masterfrom
AlexVallat wants to merge 1 commit intokintesh:masterfrom
Conversation
|
good to see another attempt to address these core issues. |
|
@kintesh |
fwiw i created Container Traffic Control to help support this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new option, "Match current container name". If enabled, the current container name is added as a prefix to match against, in angle brackets. This allows rules to control whether they apply based on the current container as well as the destination url.
Addresses:
<>prefix and it will only apply if not already in a container@<(?!personal).*>mail\.google\.com , Workand it will switch to the Work container for mail.google.com unless the current container is already Personal.@<google>(?!.+\.google\.com).* , No Containerwill allow only google.com urls in the google container