Compatibility with TC after unmapped url isolation change#74
Closed
stoically wants to merge 1 commit intokintesh:masterfrom
stoically:tmp-check
Closed
Compatibility with TC after unmapped url isolation change#74stoically wants to merge 1 commit intokintesh:masterfrom stoically:tmp-check
stoically wants to merge 1 commit intokintesh:masterfrom
stoically:tmp-check
Conversation
Contributor
Author
|
According to #70 (comment) the "unmapped urls isolation" change gets reverted, so this PR is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a possible fix for the incompatbility with TC introduced in #63. Checks for tmp container before opening unmapped urls in the default container - otherwise we end up with endlessly spawning tabs. Performance-wise it's not too bad, since
sendMessagechecks for the existence of the receiving end first, which is really fast. Did the same in TC for MAC a long time without problems, until introducing themanagementpermission.Fixes #70, stoically/temporary-containers#287 (comment), stoically/temporary-containers#286 (comment)
You could also look into the MAC API to solve #73.
Personally I'd make the feature optional as suggested in #71 - and default-off.