Skip to content

fix: include subtable id in serialized output #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kodacme wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −0
Open

fix: include subtable id in serialized output #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/kintone/client/RecordSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ private void writeSubtable(JsonGenerator gen, String fieldCode, List<TableRow> r
gen.writeArrayFieldStart("value");
for (TableRow row : rows) {
gen.writeStartObject();
if (row.getId() != null) {
gen.writeNumberField("id", row.getId());
}
gen.writeObjectFieldStart("value");
writeTableRow(row, gen);
gen.writeEndObject();
Expand Down
22 changes: 22 additions & 0 deletions src/test/java/com/kintone/client/RecordSerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,28 @@ public void serialize_SUBTABLE_empty() throws IOException {
assertThat(json).isEqualTo("{\"table\":{\"value\":[]}}");
}

@Test
public void serialize_SUBTABLE_withId() throws IOException {
TableRow row1 = new TableRow(123L).putField("text", new SingleLineTextFieldValue("test 1"));
TableRow row2 = new TableRow(456L).putField("text", new SingleLineTextFieldValue("test 2"));
Record record = new Record().putField("table", new SubtableFieldValue(row1, row2));
String json = mapper.writeValueAsString(record);
assertThat(json)
.isEqualTo(
"{\"table\":{\"value\":[{\"id\":123,\"value\":{\"text\":{\"value\":\"test 1\"}}},{\"id\":456,\"value\":{\"text\":{\"value\":\"test 2\"}}}]}}");
}

@Test
public void serialize_SUBTABLE_withAndWithoutId() throws IOException {
TableRow row1 = new TableRow(123L).putField("text", new SingleLineTextFieldValue("with id"));
TableRow row2 = new TableRow().putField("text", new SingleLineTextFieldValue("without id"));
Record record = new Record().putField("table", new SubtableFieldValue(row1, row2));
String json = mapper.writeValueAsString(record);
assertThat(json)
.isEqualTo(
"{\"table\":{\"value\":[{\"id\":123,\"value\":{\"text\":{\"value\":\"with id\"}}},{\"value\":{\"text\":{\"value\":\"without id\"}}}]}}");
}

@Test
public void serialize_TIME() throws IOException {
Record record = new Record().putField("time", new TimeFieldValue(LocalTime.of(0, 0)));
Expand Down
Loading