-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/ehk sportpalya tamogatas #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,145 @@ | ||||||||||||||||||||||
| import React, {JSX, ReactNode} from 'react'; | ||||||||||||||||||||||
| import { Card, CardContent } from '@/components/ui/card'; | ||||||||||||||||||||||
| import { PageHeader } from '@/components/common/PageHeader'; | ||||||||||||||||||||||
| import { parseFormattedText } from '@/utils/emailKatt-felkover'; //todo merge masik branchrol h letezzen a fuggveny | ||||||||||||||||||||||
|
Comment on lines
+1
to
+4
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| interface SportpalyaTamogatasContentData { | ||||||||||||||||||||||
| title: string; | ||||||||||||||||||||||
| description: string; | ||||||||||||||||||||||
| application: { | ||||||||||||||||||||||
| title: string; | ||||||||||||||||||||||
| description: string | ||||||||||||||||||||||
| }; | ||||||||||||||||||||||
| period: { | ||||||||||||||||||||||
| title: string; | ||||||||||||||||||||||
| items: string[] | ||||||||||||||||||||||
| }; | ||||||||||||||||||||||
| condition: { | ||||||||||||||||||||||
| title: string; | ||||||||||||||||||||||
| intro: string; | ||||||||||||||||||||||
| items: string[]; | ||||||||||||||||||||||
| outro: string | ||||||||||||||||||||||
| }; | ||||||||||||||||||||||
| selection: { | ||||||||||||||||||||||
| title: string; | ||||||||||||||||||||||
| description: string; | ||||||||||||||||||||||
| items: string[] | ||||||||||||||||||||||
| }; | ||||||||||||||||||||||
| result: { | ||||||||||||||||||||||
| title: string; | ||||||||||||||||||||||
| items: string[] | ||||||||||||||||||||||
| }; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| footer: string; | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| export default function SportpalyaTamogatasContent({ content }: { content: SportpalyaTamogatasContentData }) { | ||||||||||||||||||||||
| return ( | ||||||||||||||||||||||
| <div className="flex flex-col gap-4 md:gap-6 lg:px-4 px-2 py-8"> | ||||||||||||||||||||||
| <PageHeader title={content.title} /> | ||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mozgasd át ezt a page.tsx fájlba, oda jobban illik. |
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| {/* Introduction */} | ||||||||||||||||||||||
| <Card className="group hover:shadow-md transition-all duration-300"> | ||||||||||||||||||||||
| <CardContent className="p-3 md:p-6"> | ||||||||||||||||||||||
| <div className="flex flex-col gap-2 md:gap-3"> | ||||||||||||||||||||||
| <Paragraph> | ||||||||||||||||||||||
| {parseFormattedText(content.description)} | ||||||||||||||||||||||
| </Paragraph> | ||||||||||||||||||||||
| </div> | ||||||||||||||||||||||
| </CardContent> | ||||||||||||||||||||||
| </Card> | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| {/* Application */} | ||||||||||||||||||||||
| <Card className="group hover:shadow-md transition-all duration-300"> | ||||||||||||||||||||||
| <CardContent className="p-3 md:p-6"> | ||||||||||||||||||||||
| <div className="flex flex-col gap-2 md:gap-3"> | ||||||||||||||||||||||
| <h3 className="font-bold text-xl leading-tight text-gray-900 group-hover:text-[#862633] transition-colors"> | ||||||||||||||||||||||
| {content.application.title} | ||||||||||||||||||||||
| </h3> | ||||||||||||||||||||||
| <Paragraph>{parseFormattedText(content.application.description)}</Paragraph> | ||||||||||||||||||||||
| </div> | ||||||||||||||||||||||
| </CardContent> | ||||||||||||||||||||||
| </Card> | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| {/* Support Period and Location */} | ||||||||||||||||||||||
| <Card className="group hover:shadow-md transition-all duration-300"> | ||||||||||||||||||||||
| <CardContent className="p-3 md:p-6"> | ||||||||||||||||||||||
| <div className="flex flex-col gap-2 md:gap-3"> | ||||||||||||||||||||||
| <h3 className="font-bold text-xl leading-tight text-gray-900 group-hover:text-[#862633] transition-colors"> | ||||||||||||||||||||||
| {content.period.title} | ||||||||||||||||||||||
| </h3> | ||||||||||||||||||||||
| <div className="space-y-2 text-gray-700"> | ||||||||||||||||||||||
| <ul className="list-disc pl-5 space-y-2"> | ||||||||||||||||||||||
| {content.period.items.map((item, i) => ( | ||||||||||||||||||||||
| <li key={i}>{parseFormattedText(item)}</li> | ||||||||||||||||||||||
| ))} | ||||||||||||||||||||||
| </ul> | ||||||||||||||||||||||
| </div> | ||||||||||||||||||||||
| </div> | ||||||||||||||||||||||
| </CardContent> | ||||||||||||||||||||||
| </Card> | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| {/* Conditions */} | ||||||||||||||||||||||
| <Card className="group hover:shadow-md transition-all duration-300"> | ||||||||||||||||||||||
| <CardContent className="p-3 md:p-6"> | ||||||||||||||||||||||
| <div className="flex flex-col gap-2 md:gap-3"> | ||||||||||||||||||||||
| <h3 className="font-bold text-xl leading-tight text-gray-900 group-hover:text-[#862633] transition-colors"> | ||||||||||||||||||||||
| {content.condition.title} | ||||||||||||||||||||||
| </h3> | ||||||||||||||||||||||
| <p>{parseFormattedText(content.condition.intro)}</p> | ||||||||||||||||||||||
| <ol className="list-disc pl-5 space-y-1"> | ||||||||||||||||||||||
| {content.condition.items.map((item, i) => ( | ||||||||||||||||||||||
| <li key={i}>{parseFormattedText(item)}</li> | ||||||||||||||||||||||
| ))} | ||||||||||||||||||||||
| </ol> | ||||||||||||||||||||||
|
Comment on lines
+90
to
+94
|
||||||||||||||||||||||
| <ol className="list-disc pl-5 space-y-1"> | |
| {content.condition.items.map((item, i) => ( | |
| <li key={i}>{parseFormattedText(item)}</li> | |
| ))} | |
| </ol> | |
| <ul className="list-disc pl-5 space-y-1"> | |
| {content.condition.items.map((item, i) => ( | |
| <li key={i}>{parseFormattedText(item)}</li> | |
| ))} | |
| </ul> |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,24 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { getDictionary } from '@/get-dictionary'; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import type { Locale } from '@/i18n-config'; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { PageHeader } from '@/components/common/PageHeader'; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import { PageHeader } from '@/components/common/PageHeader'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ezt nem teljesen értem miért kell. Valamint ettől a tag-től más lesz az oldal tetején a layout mint a többi oldalon. Ezt töröld ki.
Copilot
AI
Feb 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The component/page/type names here refer to "Sportterem igénylés" (gym booking), but this route renders the sports field support page (dictionary.sport.sportpalyaTamogatas). Please rename the props type, page function, and local component variable to match the actual page purpose to avoid confusion and incorrect future refactors.
| import SportteremContent from './components/GymSupportContent'; | |
| type SportteremIgenylesPageProps = { | |
| params: Promise<{ lang: Locale }>; | |
| }; | |
| export default async function SportteremIgenylesPage({ | |
| params, | |
| }: SportteremIgenylesPageProps) { | |
| const { lang } = await params; | |
| const dictionary = await getDictionary(lang); | |
| return ( | |
| <div className="min-h-screen bg-gray-50"> | |
| <div className="container mx-auto px-4 py-8"> | |
| <main className="container mx-auto py-10 px-4"> | |
| <SportteremContent | |
| import SportpalyaTamogatasContent from './components/GymSupportContent'; | |
| type SportpalyaTamogatasPageProps = { | |
| params: Promise<{ lang: Locale }>; | |
| }; | |
| export default async function SportpalyaTamogatasPage({ | |
| params, | |
| }: SportpalyaTamogatasPageProps) { | |
| const { lang } = await params; | |
| const dictionary = await getDictionary(lang); | |
| return ( | |
| <div className="min-h-screen bg-gray-50"> | |
| <div className="container mx-auto px-4 py-8"> | |
| <main className="container mx-auto py-10 px-4"> | |
| <SportpalyaTamogatasContent |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -149,7 +149,7 @@ export function getNavigationItems(lang: string): NavigationItem[] { | |||||
| "Sportpálya támogatás pályázat", | ||||||
| "Sports field subsidy application" | ||||||
| ), | ||||||
| href: "#", | ||||||
| href: link("/sport/sportpalya-tamogatas"), | ||||||
|
||||||
| href: link("/sport/sportpalya-tamogatas"), | |
| href: link("/sport/sportpalyaTamogatas"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jól észrevette a copilot hogy nem jó link viszont legyen ez az url: /sport/sportpalya-tamogatas, hogy ezzel működjön át kell írni a mappa nevét erre: sportpalya-tamogatas. És akkor maradhat ez a navigation-items-ben:
href: link("/sport/sportpalya-tamogatas"),
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -148,6 +148,44 @@ | |||||
| "eszb_website": "ESZB website" | ||||||
| } | ||||||
| }, | ||||||
| "sport": { | ||||||
| "sportpalyaTamogatas": { | ||||||
| "title": "Sports Field Support Application", | ||||||
| "description": "The **Budapest University of Technology and Economics Physical Education Center** and the **University Student Council (EHK) ** are announcing a joint application to support the rental of a sports field for **BME student teams**. Our goal is to support regular sports activities among the university's citizens.", | ||||||
|
||||||
| "description": "The **Budapest University of Technology and Economics Physical Education Center** and the **University Student Council (EHK) ** are announcing a joint application to support the rental of a sports field for **BME student teams**. Our goal is to support regular sports activities among the university's citizens.", | |
| "description": "The **Budapest University of Technology and Economics Physical Education Center** and the **University Student Council (EHK)** are announcing a joint application to support the rental of a sports field for **BME student teams**. Our goal is to support regular sports activities among the university's citizens.", |
Copilot
AI
Feb 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is incomplete/awkward in English ("You can apply not only for sports activities carried out at BME sports facilities ..."). It reads like it’s missing the "but also elsewhere" part that exists in the HU version, so EN users may misunderstand the eligibility. Please revise the EN translation to match the HU meaning.
| "You can apply not only for sports activities carried out at BME sports facilities (BME Sports Center, Bogdánfy Street Sports Complex, Kármán Tódor Dormitory, Bercsényi 28-30 Dormitory)."] | |
| "You can apply not only for sports activities carried out at BME sports facilities (BME Sports Center, Bogdánfy Street Sports Complex, Kármán Tódor Dormitory, Bercsényi 28-30 Dormitory), but also for sports activities held at other external venues."] |
Copilot
AI
Feb 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text says the applications are evaluated "in cooperation with the Hungarian Academy of Sciences", but the Hungarian version states cooperation with EHK. This looks like an incorrect translation that will show wrong information to users; please correct the organization name in the EN dictionary entry.
| "description": "The applications are evaluated by the BME Physical Education Center in cooperation with the Hungarian Academy of Sciences. The main criteria are:", | |
| "description": "The applications are evaluated by the BME Physical Education Center in cooperation with the University Student Council (EHK). The main criteria are:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReactandJSXare imported but not used. This is likely to trigger lint/TS unused import errors; consider importing onlyReactNode(or nothing, if your TS/JSX runtime doesn’t require React in scope).