Restrict matching for .bin files to pytorch_model from transformers #1059
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File suffix matching for models is too broad for *.bin files, which are not necessarily models. From what we can tell, only huggingface transformers (legacy) uses this suffix. To avoid false matches, restrict matching .bin files to model weights only if the filename contains `pytorch_model` Signed-off-by: Angel Misevski <amisevsk@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR refines the file type detection logic to avoid incorrectly classifying .bin files as model weights. Instead of treating all .bin files as models, the code now only matches .bin files that contain pytorch_model in their filename, which aligns with HuggingFace transformers' legacy naming convention.
Changes:
- Removed
.binfrom the genericmodelWeightsSuffixeslist - Added a new
modelWeightsPatternsvariable with glob-style pattern matching for*pytorch_model*.binfiles - Introduced
anyPattern()function to match filenames against glob patterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gorkem
approved these changes
Jan 15, 2026
Member
gorkem
left a comment
gorkem
left a comment
There was a problem hiding this comment.
Seems to work fine.
I thought we had a test somewhere that used .binthat should be modified but could not find it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File suffix matching for models is too broad for *.bin files, which are not necessarily models. From what we can tell, only huggingface transformers (legacy) uses this suffix. To avoid false matches, restrict matching .bin files to model weights only if the filename contains
pytorch_modelLinked issues
Closes #1052
AI-Assisted Code