refactor: replace internal keyring wrapper with direct library usage #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexec
commented
Nov 22, 2025
alexec
commented
- Update go.mod with replace directive for github.com/kitproj/go-keyring v0.2.10
- Replace internal/keyring package with direct usage of github.com/zalando/go-keyring
- Remove internal/keyring package and all platform-specific implementations
- Fix test to handle nil error case properly
- Update go.mod with replace directive for github.com/kitproj/go-keyring v0.2.10 - Replace internal/keyring package with direct usage of github.com/zalando/go-keyring - Remove internal/keyring package and all platform-specific implementations - Fix test to handle nil error case properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.