Conversation
| const cache = this.cache(cache_key); | ||
| let cache = this.cache(cache_key); | ||
| cache.commands.push(irc_command); | ||
| while (cache?.tags?.batch) { |
There was a problem hiding this comment.
Call me old fashioned, but I like my caches to not change while I'm reading them.
Are you sure this is what you want to do ?
Can you define a bit more or your changes please. The changes to handler.js bother me a bit too much for this particular CR. Looking at your changes though, it LOOKS like some timing issues ? It's not clear and I see no issues linked. Help me out here! :) |
After some testing there were further changes that needed to be made, and also as you have pointed out I am also unsure of the way this PR is designed/written. I talked to @ItsOnlyBinary on Libera.Chat and his preference would be that the |
|
Im not sure on the best solution for this yet, grouping the batched events might be an issue due to the current way it collects the commands then sends the events (which behaviour needs to be kept as it makes sense), I have written some tests and been exploring options. |
3 participants
The commits refer to interleaving batches, but the patch is really for nested batches