Upgrade rpivot from Python 2.6-2.7 to Python 3.12+ #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes:
- relay.py: Convert all protocol constants to bytes literals
- client.py: Migrate exception handling, dict iteration, print, hex encoding
- server.py: Migrate exception handling, print, bytes indexing fixes
- ntlm_auth/compute_hash.py: Replace .decode('hex') with bytes.fromhex()
- ntlm_auth/compute_response.py: Remove Python 2.6 workaround
- ntlm_auth/target_info.py: Use stdlib OrderedDict directly
- ntlm_auth/ntlm.py: Fix escape sequence warning in docstring
- README.md: Update documentation for Python 3.12+
- Delete ordereddict.py and six.py (no longer needed)
Tested: All modules import successfully, server/client help commands work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Tested: All modules import successfully, server/client help commands work