You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you. The issue with this is that we're use this module on small embedded systems that has libmxml (and libexpat) available but not the lua-expat bindings. So I'd much prefer to keep the built-in serialization support to avoid another dependency. I wouldn't mind switching to libexpat instead of libmxml however.
One possibility to support both options would be to add a CMAKE option DISABLE_MXML. If enabled, mxml is not required and checked for and the respective functions are ifdef'ed out. In init.lua, we can test if xml_fromstr and xml_fromfile are defined and if not we try to load and assign the LuaExpat based implementation (preferrably from it's own module).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbusanddbus-brokerare linked withexpat(XML parsing C library).LuaExpatis available since long time with the Debian packagelua-expat.So,
xml_fromfileandxml_fromstrcould be refactored in plain Lua.By this way, the native part of
lsdbusis focused onsd-busbinding.