LFX-2025[term 1] website migration blog#271
LFX-2025[term 1] website migration blog#271jayesh9747 wants to merge 2 commits intokmesh-net:mainfrom
Conversation
Signed-off-by: jayesh9747 <112215167@cse.iiitp.ac.in>
❌ Deploy Preview for kmesh-net failed.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @jayesh9747, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new blog post that chronicles the author's LFX mentorship experience and their progression to becoming a project maintainer. It also updates the author configuration to include the new author's details, enabling proper attribution for the newly published content. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new blog post detailing an LFX mentorship experience and adds the corresponding author information. The content of the blog post is well-written. I have provided a couple of review comments. One addresses the file path of the new blog post to align it with the project's conventions and improve URL clarity. The other is a minor suggestion to ensure consistency in the authors.yml file. Additionally, please note that the Chinese translation file for authors (i18n/zh/docusaurus-plugin-content-blog/authors.yml) has not been updated with the new author, which should be addressed to maintain synchronization.
| name: Jayesh Savaliya | ||
| title: Kmesh Maintainer | ||
| url: https://github.com/jayesh9747 | ||
| image_url: https://avatars.githubusercontent.com/u/123955234 |
There was a problem hiding this comment.
For consistency with other author entries in this file, it's recommended to add the ?v=4 query parameter to the image_url. This parameter helps with cache busting when the avatar image is updated.
image_url: https://avatars.githubusercontent.com/u/123955234?v=4| --- | ||
| title: "From Contributor to Maintainer: My LFX Mentorship Journey (Or How I Accidentally Became Responsible for Things)" | ||
| authors: | ||
| - jayesh9747 | ||
| date: 2025-02-14 | ||
| sidebar_position: 2 | ||
| --- |
There was a problem hiding this comment.
The file path for this blog post seems inconsistent with the project's guidelines and the content of the post. The project's guide, docs/developer-guide/website/create-blog.md, recommends a file naming convention of YYYY-MM-DD-title.md. The current folder name lfx_2025_website_migration will also create a confusing URL slug, as the blog post is about a mentorship journey, not website migration.
It is recommended to rename the file to better reflect its content and adhere to the project's conventions. For example: blog/2025-02-14-from-contributor-to-maintainer-lfx-journey.md. Since a file rename cannot be suggested directly, please consider this change for better maintainability and user experience.
There was a problem hiding this comment.
Pull request overview
This PR adds a new blog post documenting Jayesh Savaliya's experience as an LFX Mentorship 2025 (Term 1) participant working on the Kmesh project. The blog post describes his journey from contributor to maintainer, sharing practical advice for aspiring open source contributors.
Changes:
- Added a new blog post about LFX 2025 mentorship experience with Kmesh
- Added author entry for Jayesh Savaliya to the authors configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| blog/lfx_2025_website_migration/index.md | New blog post documenting the author's journey through LFX Mentorship 2025, including strategies for getting selected, working with Kmesh, and eventually becoming a maintainer |
| blog/authors.yml | Added author entry for jayesh9747 (Jayesh Savaliya) with title "Kmesh Maintainer" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Jayesh Savaliya | ||
| title: Kmesh Maintainer | ||
| url: https://github.com/jayesh9747 | ||
| image_url: https://avatars.githubusercontent.com/u/123955234 |
There was a problem hiding this comment.
Missing "v=4" query parameter in the image URL. Other author entries in authors.yml include this parameter (e.g., line 4, 10, 16, 22, 28), so for consistency, this URL should be "https://avatars.githubusercontent.com/u/123955234?v=4".
| image_url: https://avatars.githubusercontent.com/u/123955234 | |
| image_url: https://avatars.githubusercontent.com/u/123955234?v=4 |
| sidebar_position: 2 | ||
| --- | ||
|
|
||
| ### 👋 Plot Twist: I'm Now a Maintainer |
There was a problem hiding this comment.
Why are there so many emojis inthis blog?
In my experience, ChatGPT-generated articles tend to exhibit this characteristic.
There was a problem hiding this comment.
yes correct ,i have used ai. but not only gpt use too many emojies. any ai now using too much emojies. i will remove it from blog.
Updated the blog post to refine the title and improve clarity throughout the content. Enhanced the introduction and various sections for better readability and engagement.
|
linting and singoff issues in prev commit |
3 participants
No description provided.