Skip to content

refactor: use omitzero for struct fields in API types #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kahirokunn wants to merge 1 commit into from
Closed

refactor: use omitzero for struct fields in API types #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/apis/networking/v1alpha1/certificate_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@ type Certificate struct {
// Standard object's metadata.
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata,omitzero"`

// Spec is the desired state of the Certificate.
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
// +optional
Spec CertificateSpec `json:"spec,omitempty"`
Spec CertificateSpec `json:"spec,omitzero"`

// Status is the current state of the Certificate.
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
// +optional
Status CertificateStatus `json:"status,omitempty"`
Status CertificateStatus `json:"status,omitzero"`
}

// Verify that Certificate adheres to the appropriate interfaces.
Expand All @@ -70,7 +70,7 @@ type CertificateList struct {
// Standard object's metadata.
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ListMeta `json:"metadata,omitempty"`
metav1.ListMeta `json:"metadata,omitzero"`

// Items is the list of `Certificate`.
Items []Certificate `json:"items"`
Expand Down Expand Up @@ -121,7 +121,7 @@ type HTTP01Challenge struct {
ServiceNamespace string `json:"serviceNamespace,omitempty"`

// ServicePort is the port of the service to serve HTTP01 challenge requests.
ServicePort intstr.IntOrString `json:"servicePort,omitempty"`
ServicePort intstr.IntOrString `json:"servicePort,omitzero"`
}

// GetStatus retrieves the status of the Certificate. Implements the KRShaped interface.
Expand Down
6 changes: 3 additions & 3 deletions pkg/apis/networking/v1alpha1/domainclaim_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ type ClusterDomainClaim struct {
// Standard object's metadata.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata,omitzero"`

// Spec is the desired state of the ClusterDomainClaim.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
// +optional
Spec ClusterDomainClaimSpec `json:"spec,omitempty"`
Spec ClusterDomainClaimSpec `json:"spec,omitzero"`
}

// Check that we can create OwnerReferences to a ClusterDomainClaim.
Expand All @@ -50,7 +50,7 @@ type ClusterDomainClaimList struct {
// Standard object metadata.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ListMeta `json:"metadata,omitempty"`
metav1.ListMeta `json:"metadata,omitzero"`

// Items is the list of ClusterDomainClaim objects.
Items []ClusterDomainClaim `json:"items"`
Expand Down
8 changes: 4 additions & 4 deletions pkg/apis/networking/v1alpha1/ingress_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,17 @@ type Ingress struct {
// Standard object's metadata.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata,omitzero"`

// Spec is the desired state of the Ingress.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
// +optional
Spec IngressSpec `json:"spec,omitempty"`
Spec IngressSpec `json:"spec,omitzero"`

// Status is the current state of the Ingress.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
// +optional
Status IngressStatus `json:"status,omitempty"`
Status IngressStatus `json:"status,omitzero"`
}

// Verify that Ingress adheres to the appropriate interfaces.
Expand All @@ -73,7 +73,7 @@ type IngressList struct {
// Standard object metadata.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ListMeta `json:"metadata,omitempty"`
metav1.ListMeta `json:"metadata,omitzero"`

// Items is the list of Ingress objects.
Items []Ingress `json:"items"`
Expand Down
8 changes: 4 additions & 4 deletions pkg/apis/networking/v1alpha1/serverlessservice_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@ type ServerlessService struct {
// Standard object's metadata.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ObjectMeta `json:"metadata,omitempty"`
metav1.ObjectMeta `json:"metadata,omitzero"`

// Spec is the desired state of the ServerlessService.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
// +optional
Spec ServerlessServiceSpec `json:"spec,omitempty"`
Spec ServerlessServiceSpec `json:"spec,omitzero"`

// Status is the current state of the ServerlessService.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
// +optional
Status ServerlessServiceStatus `json:"status,omitempty"`
Status ServerlessServiceStatus `json:"status,omitzero"`
}

// Verify that ServerlessService adheres to the appropriate interfaces.
Expand All @@ -72,7 +72,7 @@ type ServerlessServiceList struct {
// Standard object's metadata.
// More info: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
metav1.ListMeta `json:"metadata,omitempty"`
metav1.ListMeta `json:"metadata,omitzero"`

// Items is the list of ServerlessService.
Items []ServerlessService `json:"items"`
Expand Down
Loading