Skip to content

add shared tag-to-host helpers#1122

Open
kahirokunn wants to merge 1 commit intoknative:mainfrom
kahirokunn:kahiro/tag-to-host-support
Open

add shared tag-to-host helpers#1122
kahirokunn wants to merge 1 commit intoknative:mainfrom
kahirokunn:kahiro/tag-to-host-support

Conversation

@kahirokunn
Copy link
Member

Changes

/kind

Fixes #

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented Mar 13, 2026

@kahirokunn: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from dprotaso and dsimansk March 13, 2026 03:02
@knative-prow
Copy link

knative-prow bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from skonto March 13, 2026 03:02
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2026
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 13, 2026
@kahirokunn kahirokunn force-pushed the kahiro/tag-to-host-support branch from a5a3430 to 17e4e48 Compare March 13, 2026 03:22
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2026
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.67%. Comparing base (0055e92) to head (be4e7df).

Files with missing lines Patch % Lines
pkg/ingress/tags.go 83.78% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   93.33%   92.67%   -0.66%     
==========================================
  Files          35       36       +1     
  Lines        1005     1079      +74     
==========================================
+ Hits          938     1000      +62     
- Misses         53       59       +6     
- Partials       14       20       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn kahirokunn force-pushed the kahiro/tag-to-host-support branch from 17e4e48 to be4e7df Compare March 13, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants