Skip to content

add an annotation to the kingress mapping tags to hostnames#16455

Merged
knative-prow[bot] merged 3 commits intoknative:mainfrom
dprotaso:include-tag-to-host-map
Mar 16, 2026
Merged

add an annotation to the kingress mapping tags to hostnames#16455
knative-prow[bot] merged 3 commits intoknative:mainfrom
dprotaso:include-tag-to-host-map

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Mar 13, 2026 •
edited
Loading

Alternate approach to #16439

@knative-prow
Copy link

knative-prow bot commented Mar 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2026
@knative-prow knative-prow bot requested review from dsimansk and skonto March 13, 2026 00:33
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2026
@knative-prow
Copy link

knative-prow bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2026
@dprotaso dprotaso force-pushed the include-tag-to-host-map branch 2 times, most recently from 44e51cb to f979cca Compare March 13, 2026 00:41
@codecov
Copy link

codecov bot commented Mar 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.22%. Comparing base (07c6cde) to head (9d93ac9).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/route/resources/ingress.go 80.95% 3 Missing and 1 partial ⚠️
pkg/reconciler/route/domains/domains.go 75.00% 2 Missing ⚠️
pkg/reconciler/route/route.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16455      +/-   ##
==========================================
- Coverage   80.25%   80.22%   -0.04%     
==========================================
  Files         217      217              
  Lines       13533    13547      +14     
==========================================
+ Hits        10861    10868       +7     
- Misses       2307     2313       +6     
- Partials      365      366       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso dprotaso marked this pull request as ready for review March 13, 2026 00:48
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2026
@dprotaso dprotaso changed the title add an annotation to the kingress mapping tags to hostnames [wip] add an annotation to the kingress mapping tags to hostnames Mar 13, 2026
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2026
@dprotaso dprotaso mentioned this pull request Mar 13, 2026
Closed
@dprotaso dprotaso changed the title [wip] add an annotation to the kingress mapping tags to hostnames add an annotation to the kingress mapping tags to hostnames Mar 13, 2026
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2026
@kahirokunn
Copy link
Member

kahirokunn commented Mar 13, 2026

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2026
@kahirokunn kahirokunn mentioned this pull request Mar 13, 2026
Closed
linkvt
linkvt reviewed Mar 13, 2026
View reviewed changes
pkg/reconciler/route/resources/ingress.go Outdated
Comment on lines +230 to +235
longestDomain := ""
for d := range domains {
if len(longestDomain) < len(d) {
longestDomain = d
}
}
Copy link
Contributor

@linkvt linkvt Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this works but was wondering whether this is the best solution.
I checked GetDomainsForVisibility which only seems to be used in 3 places in total (1 is a test) - we could return the "primary domain" besides the current domains and have a deterministic choice?
Just a suggestion - I'm also fine with the current approach 😀

/lgtm
/retest
/hold in case you want to change this

Copy link
Member Author

@dprotaso dprotaso Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done - please take a look

Copy link
Contributor

@linkvt linkvt Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks great!

/lgtm

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2026
@kahirokunn kahirokunn mentioned this pull request Mar 13, 2026
Closed
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2026
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2026
@dprotaso dprotaso force-pushed the include-tag-to-host-map branch from 4e398ab to 9d93ac9 Compare March 16, 2026 14:22
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2026
@linkvt
Copy link
Contributor

linkvt commented Mar 16, 2026

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@dprotaso
Copy link
Member Author

dprotaso commented Mar 16, 2026

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2026
@knative-prow knative-prow bot merged commit d72e54b into knative:main Mar 16, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@skonto skonto Awaiting requested review from skonto

1 more reviewer

@linkvt linkvt linkvt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@linkvt linkvt

@kahirokunn kahirokunn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @kahirokunn @linkvt @knative-prow-robot