Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/prettier-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"prettier-config.js"
],
"dependencies": {
"@trivago/prettier-plugin-sort-imports": "^5.2.2",
"@trivago/prettier-plugin-sort-imports": "^6.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Module Format Mismatch Breaks Plugin Loading

Upgrading to @trivago/prettier-plugin-sort-imports v6.0.0 introduces a breaking change where the plugin switched from CommonJS to ESM. The prettier-config.js file uses CommonJS (module.exports), but the package exports configuration specifies it for both ESM import and CommonJS require. This creates a module format mismatch that will cause runtime errors when consumers try to use ESM imports, as the ESM-only plugin cannot be loaded from a CommonJS configuration file.

Fix in Cursor Fix in Web

"prettier": "^3.5.3"
}
}
69 changes: 45 additions & 24 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/generator@npm:^7.26.5, @babel/generator@npm:^7.28.0":
"@babel/generator@npm:^7.28.0":
version: 7.28.0
resolution: "@babel/generator@npm:7.28.0"
dependencies:
Expand Down Expand Up @@ -580,7 +580,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/parser@npm:^7.26.7, @babel/parser@npm:^7.28.0":
"@babel/parser@npm:^7.28.0":
version: 7.28.0
resolution: "@babel/parser@npm:7.28.0"
dependencies:
Expand Down Expand Up @@ -1973,7 +1973,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/traverse@npm:^7.26.7, @babel/traverse@npm:^7.27.3, @babel/traverse@npm:^7.28.0":
"@babel/traverse@npm:^7.27.3, @babel/traverse@npm:^7.28.0":
version: 7.28.0
resolution: "@babel/traverse@npm:7.28.0"
dependencies:
Expand Down Expand Up @@ -2013,16 +2013,6 @@ __metadata:
languageName: node
linkType: hard

"@babel/types@npm:^7.26.7, @babel/types@npm:^7.28.2":
version: 7.28.2
resolution: "@babel/types@npm:7.28.2"
dependencies:
"@babel/helper-string-parser": "npm:^7.27.1"
"@babel/helper-validator-identifier": "npm:^7.27.1"
checksum: 10c0/24b11c9368e7e2c291fe3c1bcd1ed66f6593a3975f479cbb9dd7b8c8d8eab8a962b0d2fca616c043396ce82500ac7d23d594fbbbd013828182c01596370a0b10
languageName: node
linkType: hard

"@babel/types@npm:^7.27.3, @babel/types@npm:^7.28.0":
version: 7.28.0
resolution: "@babel/types@npm:7.28.0"
Expand All @@ -2043,6 +2033,16 @@ __metadata:
languageName: node
linkType: hard

"@babel/types@npm:^7.28.2":
version: 7.28.2
resolution: "@babel/types@npm:7.28.2"
dependencies:
"@babel/helper-string-parser": "npm:^7.27.1"
"@babel/helper-validator-identifier": "npm:^7.27.1"
checksum: 10c0/24b11c9368e7e2c291fe3c1bcd1ed66f6593a3975f479cbb9dd7b8c8d8eab8a962b0d2fca616c043396ce82500ac7d23d594fbbbd013828182c01596370a0b10
languageName: node
linkType: hard

"@bcoe/v8-coverage@npm:^1.0.2":
version: 1.0.2
resolution: "@bcoe/v8-coverage@npm:1.0.2"
Expand Down Expand Up @@ -4129,7 +4129,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@knocklabs/prettier-config@workspace:packages/prettier-config"
dependencies:
"@trivago/prettier-plugin-sort-imports": "npm:^5.2.2"
"@trivago/prettier-plugin-sort-imports": "npm:^6.0.0"
prettier: "npm:^3.5.3"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -6892,29 +6892,34 @@ __metadata:
languageName: node
linkType: hard

"@trivago/prettier-plugin-sort-imports@npm:^5.2.2":
version: 5.2.2
resolution: "@trivago/prettier-plugin-sort-imports@npm:5.2.2"
"@trivago/prettier-plugin-sort-imports@npm:^6.0.0":
version: 6.0.0
resolution: "@trivago/prettier-plugin-sort-imports@npm:6.0.0"
dependencies:
"@babel/generator": "npm:^7.26.5"
"@babel/parser": "npm:^7.26.7"
"@babel/traverse": "npm:^7.26.7"
"@babel/types": "npm:^7.26.7"
"@babel/generator": "npm:^7.28.0"
"@babel/parser": "npm:^7.28.0"
"@babel/traverse": "npm:^7.28.0"
"@babel/types": "npm:^7.28.0"
javascript-natural-sort: "npm:^0.7.1"
lodash: "npm:^4.17.21"
lodash-es: "npm:^4.17.21"
minimatch: "npm:^9.0.0"
parse-imports-exports: "npm:^0.2.4"
peerDependencies:
"@vue/compiler-sfc": 3.x
prettier: 2.x - 3.x
prettier-plugin-ember-template-tag: ">= 2.0.0"
prettier-plugin-svelte: 3.x
svelte: 4.x || 5.x
peerDependenciesMeta:
"@vue/compiler-sfc":
optional: true
prettier-plugin-ember-template-tag:
optional: true
prettier-plugin-svelte:
optional: true
svelte:
optional: true
checksum: 10c0/2a4f0464f1f5a294bcd34558fb053f8263f0c62c4a7fcdd3ce40c9822a68ac8b4d951700ab6d01eb3919efe0ed44e4191997edd494d59679b22db1c0db00474e
checksum: 10c0/f964257dd0678085087b38c4f53bfa2ea4210c579163f471bf27e85aac544a05d9c51fbde2ac6c1cb6d0994fb2f6714c88d425a826eded622795a63db60d119a
languageName: node
linkType: hard

Expand Down Expand Up @@ -14628,7 +14633,7 @@ __metadata:
languageName: node
linkType: hard

"lodash@npm:^4.17.21, lodash@npm:~4.17.15":
"lodash@npm:~4.17.15":
version: 4.17.21
resolution: "lodash@npm:4.17.21"
checksum: 10c0/d8cbea072bb08655bb4c989da418994b073a608dffa608b09ac04b43a791b12aeae7cd7ad919aa4c925f33b48490b5cfe6c1f71d827956071dae2e7bb3a6b74c
Expand Down Expand Up @@ -16033,6 +16038,15 @@ __metadata:
languageName: node
linkType: hard

"parse-imports-exports@npm:^0.2.4":
version: 0.2.4
resolution: "parse-imports-exports@npm:0.2.4"
dependencies:
parse-statements: "npm:1.0.11"
checksum: 10c0/51b729037208abdf65c4a1f8e9ed06f4e7ccd907c17c668a64db54b37d95bb9e92081f8b16e4133e14102af3cb4e89870975b6ad661b4d654e9ec8f4fb5c77d6
languageName: node
linkType: hard

"parse-json@npm:^4.0.0":
version: 4.0.0
resolution: "parse-json@npm:4.0.0"
Expand Down Expand Up @@ -16064,6 +16078,13 @@ __metadata:
languageName: node
linkType: hard

"parse-statements@npm:1.0.11":
version: 1.0.11
resolution: "parse-statements@npm:1.0.11"
checksum: 10c0/48960e085019068a5f5242e875fd9d21ec87df2e291acf5ad4e4887b40eab6929a8c8d59542acb85a6497e870c5c6a24f5ab7f980ef5f907c14cc5f7984a93f3
languageName: node
linkType: hard

"parse5@npm:^8.0.0":
version: 8.0.0
resolution: "parse5@npm:8.0.0"
Expand Down
Loading