fix: rework expo push provider #823
Open
+653
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c64f0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cjbell
force-pushed
the
cjbell-kno-11205-expo-issue-with-android-push-token-registration
branch
from
1cd494e to
bf5097d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 67.33% 67.84% +0.51%
==========================================
Files 189 190 +1
Lines 7928 7934 +6
Branches 1024 1041 +17
==========================================
+ Hits 5338 5383 +45
+ Misses 2565 2526 -39
Partials 25 25
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaned up the KnockExpoPushNotificationProvider to be more readable and try and clean up some of the useEffects that existed that I suspect were the source of the bugs we've been seeing.
Introduces more ways to access the expo projectId to ensure it's loaded correctly for all Expo projects from 46+.