Skip to content

Fix race condition in element.component.js #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HaraldR42 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix race condition in element.component.js #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e7f518
Fix race condition
HaraldR42 Feb 20, 2022
4a84871
Variant that avoids dependency on FtuiApp
HaraldR42 Feb 27, 2022
458878e
Make solution more robust
HaraldR42 Feb 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions www/ftui/components/element.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ export class FtuiElement extends HTMLElement {
this.createShadowRoot(this.template());
}

if (window.ftuiApp) {
ftuiApp.attachBinding(this);
}
// solution adapted from the very useful thread https://stackoverflow.com/questions/7307983/while-variable-is-not-defined-wait
(async () => {
while (typeof window.ftuiApp === 'undefined') await new Promise(resolve => setTimeout(resolve, 2000));
if (typeof window.ftuiApp === 'object')
window.ftuiApp.attachBinding(this);
})();
}

createShadowRoot(content) {
Expand Down