fix to pass the test at node v6.x#723
Conversation
|
can you explain why this change is necessary for node 6? (btw +1 from me, I've never liked the implicit globals available through mocha) |
|
@juliangruber because node v6.x's querystring is create by Object.create(null), it doesn't have the prototype of Object.prototype, so if call ctx.query.should it would throw a error. |
|
@juliangruber see The object returned by querystring.parse() no longer inherits from Object.prototype #6055. |
|
thank you! |
|
@juliangruber you're welcome! but why haven't it added to the master branch? I have also opened a pull request to the master branch. |
|
@iyuq I'm pretty sure that PR got closed as a duplicate of this one by accident :P it shouldn't be though, they are different branches. |
|
@juliangruber so I should reopen that PR again? |
I reopened the request and squashed the 3 commits into one commit.