fix: mod11 bug with dk/cvr #136
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @koblas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a bug in the Danish CVR number validation logic by correcting the checksum calculation. The change ensures accurate validation of CVR numbers, improving the reliability of the system.
Highlights
- CVR Validation Logic Fix: Corrected the Modulo 11 checksum calculation in src/dk/cvr.ts to properly validate Danish CVR numbers, addressing an edge case where the previous calculation was incorrect.
- Enhanced Test Coverage: Added new test.each cases in src/dk/cvr.spec.ts to ensure the corrected validation logic handles various valid CVR formats, including those with and without the "DK" prefix.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the Modulo 11 checksum calculation for Danish CVR numbers and adds new test cases to cover the fix. The changes look good. I've provided a couple of suggestions for minor improvements: one to make the new tests more comprehensive, and another to simplify the updated checksum logic by removing a redundant operation. Overall, great work on this fix.
| test.each(['DK13585628', '13585628', 'DK19319970'])('validate:%s', value => { | ||
| const result = validate(value); | ||
|
|
||
| expect(result.isValid).toEqual(true); | ||
| }); |
There was a problem hiding this comment.
The new test cases are great for verifying the fix. To make them more robust, you could also assert the compact form of the number, similar to the test on line 11. This would ensure that the cleaning logic works correctly for these inputs in addition to the validation logic.
test.each([
['DK13585628', '13585628'],
['13585628', '13585628'],
['DK19319970', '19319970'],
])('validate:%s', (value, expected) => {
const result = validate(value);
expect(result.isValid && result.compact).toBe(expected);
});| weights: [2, 7, 6, 5, 4, 3, 2, 1], | ||
| }); | ||
| if (String((11 - sum) % 10) !== check) { | ||
| if (String((11 - (sum % 11)) % 11) !== check) { |
There was a problem hiding this comment.
The updated checksum logic is correct. However, it can be slightly simplified. The sum variable, which is the result of weightedSum, is already the result of a modulo 11 operation. Therefore, the additional sum % 11 within the check is redundant and can be removed for better readability.
| if (String((11 - (sum % 11)) % 11) !== check) { | |
| if (String((11 - sum) % 11) !== check) { |
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug in the mod11 checksum calculation for Danish CVR (Central Business Register) numbers by correcting the mathematical formula used for validation.
- Corrects the mod11 checksum calculation formula in the CVR validator
- Adds additional test cases to verify the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dk/cvr.ts | Updates the checksum calculation formula to properly handle mod11 arithmetic |
| src/dk/cvr.spec.ts | Adds test cases to validate the corrected checksum behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes #135