-
Notifications
You must be signed in to change notification settings - Fork 31
fix: npmjs authentication #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @koblas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a fix for npmjs authentication by modifying the repository URL format within the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes npmjs authentication issues by updating the repository URL format in package.json and modifying the GitHub Actions workflow configuration. The changes focus on improving npm publishing setup and updating Node.js version configuration.
- Updated repository URL format to include git+ prefix for proper npm registry recognition
- Modified GitHub Actions permissions and authentication setup for npm publishing
- Updated Node.js version configuration to use LTS instead of hardcoded version
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Added git+ prefix to repository URL for npm compatibility |
| .github/workflows/release.yaml | Moved permissions to job level, updated Node.js version, and commented out NPM_TOKEN |
| .github/workflows/pull_request.yaml | Updated Node.js version to LTS and removed commented npm publish action |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }} | ||
| # NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }} |
Copilot
AI
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NPM_TOKEN environment variable is commented out but the workflow still attempts to run npx semantic-release, which likely requires npm authentication for publishing. Either uncomment this line or ensure alternative authentication is configured.
| # NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }} | |
| NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }} |
| strategy: | ||
| matrix: | ||
| node-version: [22.x] | ||
| node-version: [lts/*] |
Copilot
AI
Oct 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The node-version should be a string value, not an array element. Change to node-version: 'lts/*' to match the setup-node action's expected input format.
| node-version: [lts/*] | |
| node-version: 'lts/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the repository.url in package.json to include the git+ prefix. This is a valid and more explicit format for specifying a Git repository, which can be important for tooling like semantic-release to correctly identify and interact with the repository. The change is correct and addresses the issue described in the title. I have no further suggestions.
No description provided.