Skip to content

Conversation

@koblas
Copy link
Owner

@koblas koblas commented Oct 15, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 15, 2025 07:34
@gemini-code-assist
Copy link

Summary of Changes

Hello @koblas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a fix for npmjs authentication by modifying the repository URL format within the package.json file. The update to use the git+https:// protocol ensures that npm can correctly identify and interact with the Git repository, which is essential for seamless package management and publishing processes.

Highlights

  • Repository URL Format Update: The repository.url field in package.json has been updated from https://github.com/koblas/stdnum-js.git to git+https://github.com/koblas/stdnum-js.git.
  • NPM Authentication Fix: This change is a standard practice to resolve potential authentication issues when npm interacts with Git repositories, ensuring proper handling for operations like publishing or installing packages.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/pull_request.yaml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes npmjs authentication issues by updating the repository URL format in package.json and modifying the GitHub Actions workflow configuration. The changes focus on improving npm publishing setup and updating Node.js version configuration.

  • Updated repository URL format to include git+ prefix for proper npm registry recognition
  • Modified GitHub Actions permissions and authentication setup for npm publishing
  • Updated Node.js version configuration to use LTS instead of hardcoded version

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Added git+ prefix to repository URL for npm compatibility
.github/workflows/release.yaml Moved permissions to job level, updated Node.js version, and commented out NPM_TOKEN
.github/workflows/pull_request.yaml Updated Node.js version to LTS and removed commented npm publish action

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
# NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NPM_TOKEN environment variable is commented out but the workflow still attempts to run npx semantic-release, which likely requires npm authentication for publishing. Either uncomment this line or ensure alternative authentication is configured.

Suggested change
# NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

Copilot uses AI. Check for mistakes.
strategy:
matrix:
node-version: [22.x]
node-version: [lts/*]
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node-version should be a string value, not an array element. Change to node-version: 'lts/*' to match the setup-node action's expected input format.

Suggested change
node-version: [lts/*]
node-version: 'lts/*'

Copilot uses AI. Check for mistakes.
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the repository.url in package.json to include the git+ prefix. This is a valid and more explicit format for specifying a Git repository, which can be important for tooling like semantic-release to correctly identify and interact with the repository. The change is correct and addresses the issue described in the title. I have no further suggestions.

@koblas koblas merged commit da3c325 into main Oct 15, 2025
2 checks passed
@koblas koblas deleted the fix-tokens branch October 15, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants