-
Notifications
You must be signed in to change notification settings - Fork 31
Fix-semantic-release #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-semantic-release #141
Conversation
Summary of ChangesHello @koblas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the project's publishing security and keeping its testing infrastructure up-to-date. It introduces a mechanism to verify the origin of published packages, which is a crucial step in enhancing supply chain integrity. Concurrently, it updates the core testing framework and its associated type definitions to leverage the latest features, performance improvements, and bug fixes available in their newest major releases. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes semantic-release configuration by adding npm provenance support and updating Jest-related dependencies to version 30, while pinning semantic-release to version 25.0.1 in the CI workflow.
- Added
publishConfigwith provenance enabled for npm package publishing - Updated Jest and related type definitions from version 29 to version 30
- Pinned semantic-release to specific version 25.0.1 in the release workflow
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added publishConfig for provenance and updated Jest dependencies to v30 |
| .github/workflows/release.yaml | Pinned semantic-release to version 25.0.1 during installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
5858e17 to
bbb0a25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a publishConfig to enable provenance on npm, which is a great security improvement for the release process. It also updates Jest dependencies. However, the primary goal of fixing semantic-release is not fully achieved. There is a significant issue with the semantic-release configuration being split and incorrect, which will prevent version bumps from being committed. My review provides a detailed comment on how to consolidate and correct the configuration to ensure the release process works as expected.
No description provided.