Open
Conversation
Author
|
CC @kodless (can't add you as a reviewer so I pinged you here). |
With non-AMPQ brokers `get_manager_client` returns `None` for the client which obviously doesn't have the `is_alive()` method. So we need to check if the connection driver type is AMQP otherwise `/v1/broker/queues` returns 503 with a `broker_not_reachable` error. Fix the same issue with `purge_queue()` which I haven't encountered.
adarnimrod
force-pushed
the
redis-queues-fix
branch
from
743950f to
e8232fe
Compare
|
Can we merge this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With non-AMPQ brokers
get_manager_clientreturnsNonefor the client which obviously doesn't have theis_alive()method. So we need to check if the connection driver type is AMQP otherwise/v1/broker/queuesreturns 503 with abroker_not_reachableerror. Fix the same issue withpurge_queue()which I haven't encountered.I'm not sure where are the tests, but adding a call to
/v1/broker/queueswith a Redis subscription configured would have caught it. I don't think that there's any need to update the documentation. I can open an issue if it's needed. There aren't any breaking changes with this PR (but a hotfix release would be appreciated).