This repository was archived by the owner on May 30, 2018. It is now read-only.
Open
Conversation
As this is running in the docker network, the hostnames used to connect here should the container name. This alleviates the need for any `/etc/hosts` modification. curl already has a `-k` to handle the untrusted CA, the cert name mismatch won't really matter. Seems to work on my laptop
This adds a post-setup configuration step. Along the way, it creates a `docker_curl` function, and a `get_login_token` function. I've tried to follow local style.
groob
approved these changes
Nov 30, 2017
Contributor
groob
left a comment
There was a problem hiding this comment.
Haven't tried it locally yet, but this looks nice and clean. Thanks for your work.
.gitignore
Outdated
| osquery_status | ||
| osquery_result | ||
| mysqldata/ | ||
| kolide.yml |
groob
reviewed
Nov 30, 2017
setup.json
Outdated
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "kolide_server_url": "https://kolide:8412", | |||
Author
There was a problem hiding this comment.
I updated the hostnames in the most recent push
Rename things from kolide to fleet. Enable TLS server verification in docker_curl (well, stop disabling it)
5d6661c to
fe72bb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a post setup configuration step
To keep things somewhat cleaner, I also moved all the curl calls into a
docker_curlfunction, and aget_login_tokenfunction. As well as moving the underlying setup and config data into json files.After slack discussion, I updated the hostnames from
kolidetofleet.And enabled curl's TLS ca verification