-
Notifications
You must be signed in to change notification settings - Fork 20
🐛 Fix annotated method processing #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
📝 WalkthroughWalkthroughUpdates gitignore to exclude VSCode editor files, expands method annotation query matching to include SourceMethod alongside ResolvedSourceMethod, adds necessary import statement, introduces comprehensive unit tests for MethodDeclarationSymbolProvider, and reduces target architectures in the image build workflow from four to two. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@java-analyzer-bundle.core/src/main/java/io/konveyor/tackle/core/internal/symbol/WithAnnotationQuery.java`:
- Line 10: Remove the unused import of SourceMethod from
WithAnnotationQuery.java; locate the import line "import
org.eclipse.jdt.internal.core.SourceMethod;" and delete it so only the used
types (e.g., SourceRefElement) remain imported, ensuring there are no leftover
references to SourceMethod elsewhere in the class (e.g., in methods or type
parameters).
...r-bundle.core/src/main/java/io/konveyor/tackle/core/internal/symbol/WithAnnotationQuery.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@java-analyzer-bundle.test/src/main/java/io/konveyor/tackle/core/internal/symbol/MethodDeclarationSymbolProviderTest.java`:
- Around line 53-60: The test testSetQuery currently only checks provider
non-null and doesn't validate provider.setQuery behavior; update the test to
assert the query was actually stored by either calling a new public getQuery()
on the provider or using reflection to read the private query field after
invoking provider.setQuery("com.example.ClassName.method"), and if the
provider.get() is expected to use that query ensure you add an assertion that
provider.get() results change accordingly; if no getter exists, add a simple
getQuery() to the provider class, or adjust get() to consider the query field
before asserting in the test.
🧹 Nitpick comments (1)
java-analyzer-bundle.test/src/main/java/io/konveyor/tackle/core/internal/symbol/MethodDeclarationSymbolProviderTest.java (1)
62-123: Avoid hardcoding the supported-class list in tests.
testMatchesAnnotationQueryWithoutAnnotationQuery,testBothResolvedAndSourceMethodClassesAreSupported, andtestClassesListStructureMatchesImplementationrebuild the list locally instead of exercisingMethodDeclarationSymbolProvider. These tests can pass even if the implementation changes. Consider deriving the list from the provider (or exposing a package-private accessor) and asserting against that output.
...c/main/java/io/konveyor/tackle/core/internal/symbol/MethodDeclarationSymbolProviderTest.java
Show resolved
Hide resolved
50d1bcc to
f5f794d
Compare
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Fixes: konveyor/analyzer-lsp#1079
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.