Skip to content

Simplify C code makefile#4

Open
asabil wants to merge 1 commit intomasterfrom
feature/simplify-makefile
Open

Simplify C code makefile#4
asabil wants to merge 1 commit intomasterfrom
feature/simplify-makefile

Conversation

@asabil
Copy link
Contributor

@asabil asabil commented Feb 6, 2025

No description provided.

@asabil
Copy link
Contributor Author

asabil commented Feb 6, 2025

@mrmarbury I tried simplifying the Makefile, what do you think about this?

@mrmarbury
Copy link

give me a sec I will pull it and try it out locally

@mrmarbury
Copy link

Oh you omit the arch altogether. Makes sense.
The -undefined dynamic_lookup resolves a deprecation warning in the latest macOS btw. I figured that if something is undefined there should be no harm in trying to look up resources dynamically. Should not fail any harder than ignoring things ;)

@mrmarbury
Copy link

Nicely done. should simplify things. I don't know whether -O3 would do much here. But there's no harm either. I would merge it.

@asabil
Copy link
Contributor Author

asabil commented Feb 6, 2025

Thank you for taking the time to test it on your end. I will merge this one later together with other changes and make release a 0.2.2 release.

In the mean time, I have already published 0.2.1 so you are not blocked.

@mrmarbury
Copy link

mrmarbury commented Feb 6, 2025

awesome! It's working already

Thank you

Not for that. Thank you for the nice interaction 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants