Isolate binary and Boost-dependent build components#418
Open
jacobkahn wants to merge 8 commits intokpu:masterfrom
Open
Isolate binary and Boost-dependent build components#418jacobkahn wants to merge 8 commits intokpu:masterfrom
jacobkahn wants to merge 8 commits intokpu:masterfrom
Conversation
Owner
|
This is nice. Though the |
Contributor
Author
|
Renamed to |
|
Is this going to be merged? Flashlight-text seems to rely on this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
BUILD_TOOLS(andBUILD_BENCHMARKS) options to the CMake build, which allows users to easily toggle building or not building binary-related components (that are also Boost-dependent). Getting a build of KenLM that doesn't depend on Boost (and thus doesn't build any binary components such asbuilderorinterpolate) is now as simple asAlso adds
BUILD_BENCHMARKS, which modulates building benchmarks.All defaults are set such that there is no behavior change from the current build if these options aren't specified.