In standalone Python extension, actually use the CMake build#441
Open
sdrobert wants to merge 2 commits intokpu:masterfrom
Open
In standalone Python extension, actually use the CMake build#441sdrobert wants to merge 2 commits intokpu:masterfrom
sdrobert wants to merge 2 commits intokpu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks Ken for the great library!
I noticed that #417 didn't delete the old Extension source (
FILES), which was causing the code to be compiled via the normal build_ext routine after CMake compiled its own extension. I believe CMake's standalone library was put into site-packages aslibkenlm.sobut never used. You can verify yourself by watching the output ofpip install -vv .This PR removes the old Extension source and makes sure the CMake library is loaded and named correctly. I've tested it on GCC and MSVC but not OSX. I'd appreciate someone else giving this PR a run before merging.
Thank you!
Sean