Skip to content

Made the system work without trying to do stuff with font format-files. ... #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auro1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made the system work without trying to do stuff with font format-files. ... #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/CssEmbed/CssEmbed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ protected function replace($matches)
*/
protected function embedFile($file)
{
// Check for various weird formats which the system is unable to handle. Perhaps there is a better way at some point?
if (substr($file, -4) == '.eot' || substr($file, -4) == '.ttf' || substr($file, -5) == '.woff')
Copy link
Owner

@krichprollsch krichprollsch Jan 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix indentation

Copy link
Author

@auro1 auro1 Jan 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll build a test, making sure it's not processing anything with a weird (so far, font-type), file ending and fix indentation

{
return;
}

return sprintf(self::URI_PATTERN, $this->mimeType($file), $this->base64($file));
}

Expand Down