Closed
Conversation
Fixed a bug where data with zips that unexpectedly had an EOF does not crash on a slice error when looking for the magic markers.
|
Why was this not merged? |
Owner
|
Pull was closed by OP same day it was opened. PR was never reviewed. |
Ah ok, I had this exact problem yesterday. "runtime error: slice bounds out of range [183:182]" in descriptor.go:43 Do you have time to review the PR and se if it is a good change and if it would fix it? It's a great lib btw! |
Owner
|
I hope that I will have some time to look in to this soon at work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where data with zips that unexpectedly had an EOF does not
crash on a slice error when looking for the magic markers.