Open
Conversation
Owner
|
that's a whole lot of changes for that kind of error. Care to split into logical pieces? |
Author
|
I have no idea how to do that. |
Timeout is noted to be completely unsafe, and unreliable to use. Originally, this would hang on failed UDP reads forever (noted running in jruby). Use IO#select instead, with appropriate timeout.
When returned with a failure of a response, originally this will raise a MalformedResponseError well, erroneously. The response is proper, and should carry on to raise the next error later, for proper debugging purposes.
Also fix identation, maybe travis tests?
This reverts commit b000225.
Fix specs
This reverts commit 5262935.
Fix up some bad code practice, and infinite hanging on UDP requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Causes an error: