Make it easier to use assert() #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
approved |
ksahlin
reviewed
Nov 27, 2025
Assertions (through `assert()`) are enabled by default and need to be
disabled by defining the `NDEBUG` ("no debug") macro with the compiler option
`-DNDEBUG`. CMake adds that option for all build types
(`-DCMAKE_BUILD_TYPE=...`) except `Debug`, but for `Debug`,
optimizations are entirely disabled, which makes strobealign unusable.
This commit
- enables optimizations for the `Debug` build type
- enables `-O3` instead of `-O2` for the `RelWithDebInfo` build type
- outputs a warning when assertions are enabled (they slow things down and
are not meant to be enabled for a release)
So after this commit:
- Use `-DCMAKE_BUILD_TYPE=Release` when building a release
- Use `-DCMAKE_BUILD_TYPE=Debug` for development
- Use `-DCMAKE_BUILD_TYPE=RelWithDebInfo` for profiling
marcelm
force-pushed
the
easier-assert
branch
from
fa768a2 to
f4b237c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I made this a while ago and waited until #521 was merged.)
Assertions (through
assert()) are enabled by default and need to be disabled by defining theNDEBUG("no debug") macro with the compiler option-DNDEBUG. CMake adds that option for all build types (-DCMAKE_BUILD_TYPE=...) exceptDebug, but forDebug, optimizations are entirely disabled, which makes strobealign unusable.This commit
Debugbuild type-O3instead of-O2for theRelWithDebInfobuild typeSo after this commit:
-DCMAKE_BUILD_TYPE=Releasewhen building a release-DCMAKE_BUILD_TYPE=Debugfor development-DCMAKE_BUILD_TYPE=RelWithDebInfofor profiling