Fix compilation with current readline#52
Draft
ryandesign wants to merge 1 commit intoksherlock:masterfrom
Draft
Conversation
"Function *" was deprecated in readline 4.2 and removed in readline 6.3. And at some point it evidently also became required to include <readline/history.h> to use the history functions like "add_history".
Contributor
Author
|
While this PR makes the code compile successfully with GNU readline 8.1.2.000 (and I'm not sure how one is meant to write software that is compatible with both readline and editline. It doesn't help that there appear to be several different projects calling themselves "libedit" or "editline". |
Owner
|
When I was working on linux port, I did this: For another project that handled both, I did this, which is cleaner: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following errors I got when trying to compile the latest code on macOS 12.3.1 with readline 8.1.2.000 installed (using MacPorts):
Function *is an ancient readline type which no longer exists.Function *and friends were deprecated in readline 4.2 (released April 2001) and removed in readline 6.3 (released February 2014).The
add_historyandcurrent_historyfunctions and theHIST_ENTRYtype appear to be defined in<readline/history.h>which I guess needs to be included separately now.