feat: DiscountEventListener 개발 #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeemin65-pixel
approved these changes
Jan 3, 2026
Contributor
jeemin65-pixel
left a comment
jeemin65-pixel
left a comment
There was a problem hiding this comment.
확인했습니다 감사합니다! 고생하셨습니다 ㅜㅜ
중복 알림 방지는 Set 으로 처리해주신 것으로 이해했는데, 이 방식으로 진행하신다면 제가 만들어둔 notificationHistory ERD 는 제거해도 될지 확인 부탁드립니다!
Contributor
Author
일단 set으로 해결할수있을거 같아서 진행했는데 다른 팀원들이랑 notificationHistory를 만드는게 나을지 set으로 처리하는게 나을지 월요일 회의때 이야기 해보고 정하면 좋을듯합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝요약(Summary)
이슈 번호 : #124
🔨변경 사항(Changes)
😉리뷰 요구사항
전반적인 흐름이 괜찮은지 봐주시면 감사하겠습니다