Skip to content

refactor(binder): update type checking to use bidirectional type inference #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kthompson merged 1 commit into from
Dec 27, 2025
Merged

refactor(binder): update type checking to use bidirectional type inference #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pnc/src/Binder.pn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,12 +630,12 @@ class Binder(
options match {
case FieldOptions.TypeAndExpression(fieldType, expression) =>
// TODO: this expression needs to be added to the symbol's constructor body
val expr = exprBinder.bindConversionExpr(expression, fieldType, scope)
val expr = exprBinder.check(expression, fieldType, scope)
setSymbolType(symbol, fieldType)
case FieldOptions.TypeOnly(fieldType) =>
setSymbolType(symbol, fieldType)
case FieldOptions.ExpressionOnly(expression) =>
val expr = exprBinder.bind(expression, scope)
val expr = exprBinder.infer(expression, scope)
// TODO: this expression needs to be added to the symbol's constructor body
val returnType = getType(expr)
setSymbolType(symbol, returnType)
Expand All @@ -657,9 +657,9 @@ class Binder(
case Option.Some(expression) =>

val boundExpr = returnType match {
case Option.None => exprBinder.bind(expression, methodScope)
case Option.None => exprBinder.infer(expression, methodScope)
case Option.Some(toType) =>
exprBinder.bindConversionExpr(expression, toType, methodScope)
exprBinder.check(expression, toType, methodScope)
}

functionBodies = functionBodies.put(symbol, boundExpr)
Expand Down
Loading