KTOR-9198: Ignore WWW-Authenticate header when only a single AuthProvider is available #5264
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
KTOR Client - Auth plugin
Motivation
As described in KTOR-9198, multiple large cloud services do not return WWW-Authenticate headers for every possible auth type that could potentially be used. This causes issues when a user tries to use an auth type that is not specified in the header. KTOR Client runs the
isApplicablefunction, which returns false due to the non-matching header.Solution
My solution is to have the
findProviderfunction ignore the presence of the WWW-Authenticate header if only a single AuthProvider implementation is available. In my opinion, it can be assumed that a user who provides only a single auth provider would want that auth provider to be used for all calls being made through that client instance.