chore(hub): add OWNERS file to kubeflow.hub#244
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom Jan 27, 2026
Merged
chore(hub): add OWNERS file to kubeflow.hub#244google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom
Conversation
google-oss-prow
bot
requested review from
Electronic-Waste,
astefanutti and
szaher
Pull Request Test Coverage Report for Build 21372491147Details
💛 - Coveralls |
Member
Author
google-oss-prow
bot
requested review from
andreyvelich,
kramaranya and
tarilabs
kubeflow/hub/OWNERS
Outdated
| @@ -0,0 +1,16 @@ | |||
| approvers: | |||
| - Al-Pragliola | |||
| - andreyvelich # noqa(kubeflow-hub-team) | |||
Member
There was a problem hiding this comment.
You can remove me from here.
Suggested change
| - andreyvelich # noqa(kubeflow-hub-team) |
kubeflow/hub/OWNERS
Outdated
Comment on lines
+12
to
+16
| reviewers: | ||
| - Al-Pragliola | ||
| - andreyvelich | ||
| - jonburdo | ||
| - pboyd |
Member
There was a problem hiding this comment.
You don't need to duplicate folks in reviewers who already in the approvers list.
This copies the OWNERS file from the root of the model-registry repo to kubeflow/hub/OWNERS since the kubeflow hub working group owns this particular sub-module. The model-registry repo is: https://github.com/kubeflow/model-registry This OWNERS file is specifically sourced from: https://github.com/kubeflow/model-registry/blob/c9222d84c04586c8d9fa95b6e5564f93869e6451/OWNERS Signed-off-by: Jon Burdo <jon@jonburdo.com>
jonburdo
force-pushed
the
add-kubeflow-hub-owners-file
branch
from
1cc8482 to
0bc68a3
Compare
Member
Author
|
Updated. Now the file is copied from latest
I will also clean these up in |
Member
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks @jonburdo!
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
we kept those for git-blame on the history, but fine with me if we want to be more adherent to this |
jonburdo
added a commit
to jonburdo/model-registry
that referenced
this pull request
Feb 2, 2026
This cleans up the root OWNERS file to follow best-practice and to match the state of the kubeflow sdk file: https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS after the following PR is merged: kubeflow/sdk#252 Specifically this does the following: - move andreyvelich to emeritus_approvers (no longer active) (per this comment: kubeflow/sdk#244 (comment) ) - remove duplicate reviewers entries which are also in approvers: - Al-Pragliola - pboyd Also see: kubeflow/sdk#244 (comment) Following this, these OWNERS files should be kept in sync: https://github.com/kubeflow/model-registry/blob/main/OWNERS https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS Signed-off-by: Jon Burdo <jon@jonburdo.com>
8 tasks
jonburdo
added a commit
to jonburdo/model-registry
that referenced
this pull request
Feb 3, 2026
This cleans up the root OWNERS file to follow best-practices and more closely match the state of the kubeflow sdk file: https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS Specifically this does the following: - remove duplicate reviewers entries which are also in approvers: - andreyvelich - Al-Pragliola - pboyd Also see: kubeflow/sdk#244 (comment) Signed-off-by: Jon Burdo <jon@jonburdo.com>
google-oss-prow bot
pushed a commit
to kubeflow/model-registry
that referenced
this pull request
Feb 9, 2026
This cleans up the root OWNERS file to follow best-practices and more closely match the state of the kubeflow sdk file: https://github.com/kubeflow/sdk/blob/main/kubeflow/hub/OWNERS Specifically this does the following: - remove duplicate reviewers entries which are also in approvers: - andreyvelich - Al-Pragliola - pboyd Also see: kubeflow/sdk#244 (comment) Signed-off-by: Jon Burdo <jon@jonburdo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies the OWNERS file from the root of the model-registry repo to kubeflow/hub/OWNERS since the kubeflow hub working group owns this particular sub-module.
The model-registry repo is: https://github.com/kubeflow/model-registry
This OWNERS file is specifically sourced from: https://github.com/kubeflow/model-registry/blob/c9222d84c04586c8d9fa95b6e5564f93869e6451/OWNERS
What this PR does / why we need it:
The kubeflow hub working group owns the code under
kubeflow/hub. This was mentioned as a next step to adding this sub-module:Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: