chore(spark): Refactor unit tests to follow standards#314
chore(spark): Refactor unit tests to follow standards#314priyank766 wants to merge 1 commit intokubeflow:mainfrom
Conversation
Signed-off-by: priyank <priyank8445@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
There was a problem hiding this comment.
Pull request overview
Refactors the SparkClient unit tests to match the Kubeflow SDK’s standardized, parametrized TestCase pattern, reducing per-method boilerplate while keeping the same behavioral coverage targets.
Changes:
- Replaced individual initialization tests with a single
@pytest.mark.parametrize-driventest_spark_client_init. - Replaced session-management method tests with a single parametrized
test_spark_client_session_management. - Adopted
TestCaseplusSUCCESS/FAILEDconstants fromkubeflow.trainer.test.commonfor consistency.
|
/retitle chore(spark): Refactor unit tests to follow standards |
|
@priyank766 can you rebase your PR, the e2e test should be fixed after. |
ab886f2 to
bc33273
Compare
Done @astefanutti |
|
This is resolved in: #293 |
|
@andreyvelich: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR refactors the SparkClient unit tests in [kubeflow/spark/api/spark_client_test.py]
(kubeflow-sdk/kubeflow/spark/api/spark_client_test.py:0:0-0:0) to align with the standardized testing patterns used throughout the Kubeflow SDK.
Key changes include:
@pytest.mark.parametrize.SUCCESS/FAILEDconstants fromkubeflow.trainer.test.commonfor consistency across client test suites.Which issue(s) this PR fixes:
Fixes #273
Checklist: