chore(trainer): clarify namespace binding and CustomTrainer inputs (KEP-936)#324
chore(trainer): clarify namespace binding and CustomTrainer inputs (KEP-936)#324sjiang83 wants to merge 1 commit intokubeflow:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
There was a problem hiding this comment.
Pull request overview
Adds a “Design notes (KEP-936 alignment)” block to the first Trainer quickstart in the root README to clarify intended SDK vs API usage, namespace binding behavior, and the intended scope of MCP-facing tooling guidance.
Changes:
- Adds a KEP-936 design-notes block before the Trainer quickstart code sample.
- Documents namespace binding as a
TrainerClient/KubernetesBackendConfigconcern rather than a per-call parameter. - Introduces guidance on CustomTrainer input format and an MVP tool-surface stance for MCP integrations.
62b243f to
ce8438a
Compare
Signed-off-by: Shanhuizi Jiang <sjiang83@fordham.edu>
ce8438a to
7bb2984
Compare
This PR adds a short "Design Notes (KEP-936 alignment)" block to the first Trainer quickstart example in the README.
It clarifies:
TrainerClientbinds namespace viaKubernetesBackendConfig(namespace=...)(not per-call).namespaceas an explicit tool parameter and create/cache a per-namespace client internally.script_code: strover serializing Python callables (with a brief validation/security roadmap).Docs-only; no behavior changes.