feat: add scaffolding for feature gates#3102
feat: add scaffolding for feature gates#3102google-oss-prow[bot] merged 6 commits intokubeflow:masterfrom
Conversation
|
/assign @andreyvelich @tenzen-y Here's a small PR that adds scaffolding for feature gates. I've followed the approach used by jobset. Please can you take a look when you get a chance. |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks for this @robert-bell!
lgtm, just a few small nits.
/assign @tenzen-y @astefanutti
go.mod
Outdated
| golang.org/x/crypto v0.47.0 | ||
| k8s.io/api v0.34.3 | ||
| k8s.io/apimachinery v0.34.3 | ||
| k8s.io/apiserver v0.34.1 |
There was a problem hiding this comment.
Let's keep the same version
| k8s.io/apiserver v0.34.1 | |
| k8s.io/apiserver v0.34.3 |
There was a problem hiding this comment.
Done. Please take a look.
pkg/features/features.go
Outdated
| ) | ||
|
|
||
| // TODO(robert-bell): enable as part of #2779 | ||
| //const ( |
There was a problem hiding this comment.
We might want to add owner + KEP number like here: https://github.com/kubernetes-sigs/kueue/blob/main/pkg/features/kube_features.go#L32-L35
There was a problem hiding this comment.
I've added a comment. I've put myself as owner, but I'm happy to change that that if you'd prefer the owner to be a maintainer.
There was a problem hiding this comment.
@robert-bell Please can you create PR to add yourself to the Kubeflow GitHub org: https://github.com/kubeflow/internal-acls?tab=readme-ov-file#joining-the-kubeflow-github-organization?
I am happy to support it!
Pull Request Test Coverage Report for Build 21284007848Details
💛 - Coveralls |
Signed-off-by: Rob Bell <robell@redhat.com>
Signed-off-by: Rob Bell <robell@redhat.com>
Signed-off-by: Rob Bell <robell@redhat.com>
Signed-off-by: Rob Bell <robell@redhat.com>
Signed-off-by: Rob Bell <robell@redhat.com>
robert-bell
force-pushed
the
feature-gate-scaffolding
branch
from
0457bb2 to
7f10b29
Compare
pkg/features/features.go
Outdated
| featuregatetesting "k8s.io/component-base/featuregate/testing" | ||
| ) | ||
|
|
||
| // TODO(robert-bell): enable as part of #2779 |
There was a problem hiding this comment.
I'd suggest to add that with the actual implementation of 2779.
pkg/features/features.go
Outdated
| // Entries are separated from each other with blank lines to avoid sweeping gofmt changes | ||
| // when adding or removing one entry. | ||
| var defaultFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{ | ||
| // TODO(robert-bell): enable as part of #2779 |
There was a problem hiding this comment.
dito: I'd suggest to add that with the actual implementation of 2779.
Signed-off-by: Rob Bell <robell@redhat.com>
|
Thanks @robert-bell! /lgtm @tenzen-y in case you have any comments before approving. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
What this PR does / why we need it:
This PR adds scaffolding for feature gates, following the approach used in jobset operator following kubernetes-sigs/jobset#557.
This is prep work ready for implementing the progress tracking feature in #2905 which will be implemented behind a feature gate.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: