feat(flux): enhance TestFlux with proper error and info validation#3181
Closed
Raakshass wants to merge 5 commits intokubeflow:masterfrom
Closed
feat(flux): enhance TestFlux with proper error and info validation#3181Raakshass wants to merge 5 commits intokubeflow:masterfrom
Raakshass wants to merge 5 commits intokubeflow:masterfrom
Conversation
Flux supports the majority of MPI flavors/variants, and can be used to bootstrap MPI as a plugin. It adds other features for scheduling and topology that can be used for simulations and ai/ml jobs. This changeset adds the plugin implementation, including the plugin module, tests, and an example with a small README to serve as documentation for the time being. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Following the MPI plugin testing pattern, this commit adds: - wantMLPolicyError field to verify EnforceMLPolicy error handling - wantInfo field to verify info object after EnforceMLPolicy - wantBuildError field to verify Build error handling - gocmp.Diff comparisons with cmpopts.EquateErrors() for proper error comparison Fixes kubeflow#3179
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enhances the TestFlux function in pkg/runtime/framework/plugins/flux/flux_test.go to follow the same testing pattern used by the MPI plugin, as discussed in #3064 (comment).
Changes:
wantMLPolicyErrorfield to verifyEnforceMLPolicy()error handlingwantInfofield to verify info object state afterEnforceMLPolicy()wantBuildErrorfield to verify Build() error handlinggocmp.Diffwithcmpopts.EquateErrors()for proper error comparisonutiltesting.PodSetEndpointsCmpOptsThis mirrors the testing strategy of the MPI plugin for consistency across plugins.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #3179
Checklist:
No docs needed - changes are limited to test file only.