Skip to content

Open external links in new tab (fixes #4314)#4315

Open
rohit-bharmal wants to merge 1 commit intokubeflow:masterfrom
rohit-bharmal:fix-website-external-links-4314
Open

Open external links in new tab (fixes #4314)#4315
rohit-bharmal wants to merge 1 commit intokubeflow:masterfrom
rohit-bharmal:fix-website-external-links-4314

Conversation

@rohit-bharmal
Copy link

  • Add Hugo link render hook so markdown external links get target=_blank and rel=noopener noreferrer
  • Add rel=noopener noreferrer to navbar and feedback partials for external links

Closes #4314

@google-oss-prow
Copy link

Hi @rohit-bharmal. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added the area/website AREA: Website Styles/Hosting/Serving label Feb 17, 2026
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

🚫 This command cannot be processed. Only organization members or owners can use the commands.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

- Add Hugo link render hook so markdown external links get target=_blank and rel=noopener noreferrer
- Add rel=noopener noreferrer to navbar and feedback partials for external links

Signed-off-by: rohitbharmal <rbharmal@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: rohitbharmal <rohitbharmal123@gmail.com>
@rohit-bharmal rohit-bharmal force-pushed the fix-website-external-links-4314 branch from 6755343 to 34c9c31 Compare February 19, 2026 10:30
@rohit-bharmal
Copy link
Author

@Arhell Did you get some time to review this PR ? If not, could you please review this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/website AREA: Website Styles/Hosting/Serving ok-to-test size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug()website: All external links should open in new tab

2 participants