Open external links in new tab (fixes #4314)#4315
Open external links in new tab (fixes #4314)#4315rohit-bharmal wants to merge 1 commit intokubeflow:masterfrom
Conversation
|
Hi @rohit-bharmal. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
7a3a04e to
6755343
Compare
- Add Hugo link render hook so markdown external links get target=_blank and rel=noopener noreferrer - Add rel=noopener noreferrer to navbar and feedback partials for external links Signed-off-by: rohitbharmal <rbharmal@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: rohitbharmal <rohitbharmal123@gmail.com>
6755343 to
34c9c31
Compare
|
@Arhell Did you get some time to review this PR ? If not, could you please review this PR ? |
Closes #4314