Conversation
|
Hi @Ashish241. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
Signed-off-by: Ashish Kumar <ashishkum2411@gmail.com>
Signed-off-by: Ashish241 <93699973+Ashish241@users.noreply.github.com>
|
Hi maintainers, This PR is ready for review. I have addressed the DCO issue and verified the changes locally with Hugo v0.124.1. Kindly let me know if any modifications are required. Thank you. |
andreyvelich
left a comment
andreyvelich
left a comment
There was a problem hiding this comment.
The UX looks good to me, since we have GitHub links to the Kubeflow projects.
@varodrig @tarekabouzeid @franciscojavierarceo @StefanoFioravanzo any thoughts?
| <div id="cncf" class="text-center"> | ||
| <div class="container"> | ||
| <div class="mx-auto col-md-4"> | ||
| <img src="/docs/images/logos/cncf.svg" draggable="false" class="show_light-only img-fluid | ||
| alt=" Cloud Native Computing Foundation Logo" /> | ||
| <img src="/docs/images/logos/cncf-white.svg" draggable="false" class="show_dark-only img-fluid | ||
| alt=" Cloud Native Computing Foundation Logo" /> | ||
| </div> | ||
| <div class="cncf-title">We are a Cloud Native Computing Foundation project.</div> | ||
| </div> | ||
| </div> No newline at end of file |
There was a problem hiding this comment.
Please can you remove changes unrelated to this PR?
| class="argo-github-btn" title="GitHub Repository" data-github-repo="kubeflow/training-operator"> | ||
| <i class="fab fa-github"></i> | ||
| <i class="far fa-star"></i> | ||
| <span>2.0k</span> |
There was a problem hiding this comment.
Do we require to manually update these values?
Is there a way to dynamically fetch it from the GitHub API?
There was a problem hiding this comment.
Yes, I can integrate dynamic star fetching without compromising the Core Web Vitals. By using placeholders and deferred JavaScript, i can keep the PageSpeed score high and the SEO intact.
I can wrap this feature into my current workflow along with the other requested changes to keep the PR clean and efficient. Let me know if you’d like me to include this in my next push.
There was a problem hiding this comment.
I think, that is better, so we don't need to always update these values manually.
| </p> | ||
| <div class="mt-auto d-flex justify-content-center"> | ||
| <a href="https://github.com/kubeflow/kubeflow" target="_blank" rel="noopener" class="argo-github-btn" | ||
| title="GitHub Repository" data-github-repo="kubeflow/kubeflow"> |
There was a problem hiding this comment.
The link should be kubeflow/notebooks: https://github.com/kubeflow/notebooks
| </p> | ||
| <div class="mt-auto d-flex justify-content-center"> | ||
| <a href="https://github.com/kubeflow/kubeflow" target="_blank" rel="noopener" class="argo-github-btn" | ||
| title="GitHub Repository" data-github-repo="kubeflow/kubeflow"> |
There was a problem hiding this comment.
The link should be kubeflow/dashboard: https://github.com/kubeflow/dashboard
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
There was a problem hiding this comment.
/lgtm
/approve
|
@andreyvelich i love it |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: franciscojavierarceo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Add GitHub star count to homepage
Fixes #3624
Summary:
This PR adds a GitHub star count section to the homepage.
Details:
Integrated star count display in hero section
Matches existing CSS styling
No additional heavy dependencies introduced
Tested locally with Hugo v0.124.1
Screenshots:
Before
After
Let me know if any adjustments are required.