Add proxy support

[krmodelski]

Similar to 2091, but for the release-1.x branch. I did not add tests this time because I had some troubles with copying agent options in the applyToHTTPSOptions method. I might work on tests in the meantime. I am using different library for HTTP/HTTPS due to this issue in previous library.

[brendandburns]

Some comments.

Given that there seems to be a typo/reverse bug in the code, I think we should really figure out how to get unit tests on this.

[cjihrig]

I agree that we should not land this without tests - particularly if most future development is intended to target this branch.

[cjihrig]

Thanks for addressing the nits. At this point, are you able to add tests?

[krmodelski]

Thanks for addressing the nits. At this point, are you able to add tests?

I think I can do it.

[CGNonofr]

exec doesn't seem to work 🤔 should'nt the config#applyToHTTPSOptions method be changed as well?

[krmodelski]

exec doesn't seem to work 🤔 should'nt the config#applyToHTTPSOptions method be changed as well?

@CGNonofr thanks for heads-up, I will take a look at it.

[krmodelski]

@CGNonofr I added agent to applyToHTTPSOptions and tested exec. Could you please confirm it works?

[CGNonofr]

@CGNonofr I added agent to applyToHTTPSOptions and tested exec. Could you please confirm it works?

Looks good!

[brendandburns]

This looks good to me, thanks for adding tests.

@cjihrig I'll leave it to you to give the final lgtm+approve.

[cjihrig]

Thanks for the contribution.

/lgtm
/approve

[cjihrig]

I don't think I can merge this yet. I think #2124 needs to land first.

[cjihrig]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, krmodelski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cjihrig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cjihrig]

@krmodelski it looks like there are some issues with the test here - https://github.com/kubernetes-client/javascript/actions/runs/12439738691/job/34734042786:

> tsc --project tsconfig-with-tests.json && cp 'src/test/echo space.js' dist/test

src/config_test.ts:399:26 - error TS2339: Property 'proxy' does not exist on type 'HttpsProxyAgent'.

399             expect(agent.proxy.href).to.equal(expectedProxyHref);
                             ~~~~~

src/config_test.ts:415:26 - error TS2339: Property 'options' does not exist on type 'HttpProxyAgent'.

415             expect(agent.options.ca?.toString()).to.equal(expectedCA.toString());
                             ~~~~~~~

src/config_test.ts:416:26 - error TS2339: Property 'proxy' does not exist on type 'HttpProxyAgent'.

416             expect(agent.proxy.href).to.equal(expectedProxyHref);

I think this wasn't caught initially because the PR branch didn't include the new checks for the tests and transpiled code.

Are you able to take a look?

[krmodelski]

@krmodelski it looks like there are some issues with the test here - https://github.com/kubernetes-client/javascript/actions/runs/12439738691/job/34734042786:

> tsc --project tsconfig-with-tests.json && cp 'src/test/echo space.js' dist/test

src/config_test.ts:399:26 - error TS2339: Property 'proxy' does not exist on type 'HttpsProxyAgent'.

399             expect(agent.proxy.href).to.equal(expectedProxyHref);
                             ~~~~~

src/config_test.ts:415:26 - error TS2339: Property 'options' does not exist on type 'HttpProxyAgent'.

415             expect(agent.options.ca?.toString()).to.equal(expectedCA.toString());
                             ~~~~~~~

src/config_test.ts:416:26 - error TS2339: Property 'proxy' does not exist on type 'HttpProxyAgent'.

416             expect(agent.proxy.href).to.equal(expectedProxyHref);

I think this wasn't caught initially because the PR branch didn't include the new checks for the tests and transpiled code.

Are you able to take a look?

Sure, I will take a look.

[krmodelski]

@krmodelski it looks like there are some issues with the test here - https://github.com/kubernetes-client/javascript/actions/runs/12439738691/job/34734042786:

> tsc --project tsconfig-with-tests.json && cp 'src/test/echo space.js' dist/test

src/config_test.ts:399:26 - error TS2339: Property 'proxy' does not exist on type 'HttpsProxyAgent'.

399             expect(agent.proxy.href).to.equal(expectedProxyHref);
                             ~~~~~

src/config_test.ts:415:26 - error TS2339: Property 'options' does not exist on type 'HttpProxyAgent'.

415             expect(agent.options.ca?.toString()).to.equal(expectedCA.toString());
                             ~~~~~~~

src/config_test.ts:416:26 - error TS2339: Property 'proxy' does not exist on type 'HttpProxyAgent'.

416             expect(agent.proxy.href).to.equal(expectedProxyHref);

I think this wasn't caught initially because the PR branch didn't include the new checks for the tests and transpiled code.
Are you able to take a look?

Sure, I will take a look.

This should fix.