Do not close whole websocket when v5 protocol is supported

[CGNonofr]

Recently the v5.channel.k8s.io was implemented allowing to close exec streams.

But the close still closes the whole websocket when the stdin is closed

[linux-foundation-easycla]

• ❌ The email address for the commit (e808e68) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CGNonofr
Once this PR has been reviewed and has the lgtm label, please assign mstruebing for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @CGNonofr!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Thank you for the fix! This should probably be ported to release-1.x branch also.

[brendandburns]

Also we need you to sign the CLA.

[CGNonofr]

Also we need you to sign the CLA.

I looks like a really heavy process for a so small change, I'm not sure I want to provide my mailing address either.

I authorize you to close that PR and open one of yours with the fix!

[cjihrig]

I authorize you to close that PR and open one of yours with the fix!

@brendandburns is there any policy for shepherding in a change under these circumstances?

[brendandburns]

@cjihrig apologies, I missed your comment.

In general, I tend to do a clean-room reimplementation and send a PR.

[cjihrig]

Created a new patch on the main release line in #2144.

I guess I'll close this out. Thanks for the PR anyway.

/close

[mstruebing]

Closing as this was done in #2144