test: support testing transpiled code#2122
test: support testing transpiled code#2122k8s-ci-robot merged 2 commits intokubernetes-client:release-1.xfrom
Conversation
This commit makes it possible to execute the tests after transpilation. This should provide additional confidence that the code shipped to npm works as intended.
mstruebing
left a comment
There was a problem hiding this comment.
I think we should do this for every PR instead of only the release job.
That way we know for sure that the current code works and don't find out when we want to release.
|
Added to the PR job. It seems to work. |
|
/lgtm Thanks for doing this! We should run it on all PRs, otherwise it will be really painful whenever we try to do a release and things have been broken for a while. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cjihrig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit makes it possible to execute the tests after transpilation. This should provide additional confidence that the code shipped to npm works as intended.
I think we'll also want to integrate this into the CI. Should it be for every PR, or the release job only?