Merged
Conversation
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable trusted publishing on
mainso we are not dependent on @brendanburns updating the npm token anymore. 🚀In my test-repo it worked with NodeJS 25 out of the box as it seems to contain the minimum required npm version.
As we are running our tests with NodeJS 25 as well I don't think it's a problem to increase the version in here as well.
As this is
mainwe use the tag latest, I explicitly added it so that whenever we need to release from an older branch again and get an error it's easier to spot whats wrong.I don't really bother to adjust the other release branches release workflow, we seldom release patch versions and if we really need to, we can make these adjustments.