add useragent with package version#2744
Conversation
k8s-ci-robot
added
approved
davidgamero
force-pushed
the
useragent
branch
from
08e5759 to
cc4cbe9
Compare
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with some minor nits.
|
thank you i've updated to include the suggestions |
src/config.ts
Outdated
|
|
||
| function getUserAgent(): string { | ||
| const version = packagejson.version ?? ''; | ||
| return `kubernetes-javascript-client/${version}`; |
There was a problem hiding this comment.
Should we name it kubernetes-client-javascript to better match the org/repo name?
There was a problem hiding this comment.
makes sense to me
src/config_test.ts
Outdated
| true, | ||
| `User-Agent should include version ${expectedVersion}`, | ||
| ); | ||
| t.after(async () => { |
There was a problem hiding this comment.
This should be moved to right after the server is started. Otherwise, if any assertions fail, this will never be added.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, davidgamero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
make debugging easier by including a user agent with package version
following similar pattern to go client https://github.com/kubernetes/client-go/blob/0b06cf5bf0e19c0f026fd5eef7eecb5a346ca95f/rest/config.go#L524