Skip to content

🐛 fix +listType marker not working on type alias fields#1359

Open
sivchari wants to merge 1 commit intokubernetes-sigs:mainfrom
sivchari:fix-issue-988-listtype-type-alias
Open

🐛 fix +listType marker not working on type alias fields#1359
sivchari wants to merge 1 commit intokubernetes-sigs:mainfrom
sivchari:fix-issue-988-listtype-type-alias

Conversation

@sivchari
Copy link
Member

@sivchari sivchari commented Mar 8, 2026

Include underlying type info (array/object) in schema for slice/map type aliases, allowing field-level markers like +listType to work.

Fixes #988

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 8, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sivchari
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2026
@sivchari sivchari force-pushed the fix-issue-988-listtype-type-alias branch from 06bfcda to a39b281 Compare March 9, 2026 02:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2026
Include underlying type info (array/object) in schema for slice/map
type aliases, allowing field-level markers like +listType to work.

Fixes kubernetes-sigs#988

Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the fix-issue-988-listtype-type-alias branch from a39b281 to 639035d Compare March 9, 2026 02:40
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 639035d Fix +listType marker not working on type alias fields
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

controller-gen: Type aliases to array types don't work with +listType/+listMapKey markers

2 participants