Skip to content

✨Implement opaque declarative validation marker#1360

Open
itzPranshul wants to merge 2 commits intokubernetes-sigs:mainfrom
itzPranshul:opaque
Open

✨Implement opaque declarative validation marker#1360
itzPranshul wants to merge 2 commits intokubernetes-sigs:mainfrom
itzPranshul:opaque

Conversation

@itzPranshul
Copy link

What does this do, and why do we need it?

When a Go type has type-level validation markers, those markers are automatically inherited by all fields that use that type. This PR introduces +k8s: opaque, a field-level marker that suppresses type-level validation inheritance for a specific field.

This marker gives users a way to opt-out of type level validations when reusing a go type in a CRD struct field, so they can define custom field level validations without inheriting any conflicts.

Which issue(s) this PR is related to:

Fixes #1301

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itzPranshul
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @itzPranshul. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2026
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Can you please also add an envtest-based test?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2026
This commit introduces , a field-level marker that suppresses type-level validation inheritance for a specific field, while still allowing field-level markers
an API server integration test to verify validation exactly kubernetes would execute it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Provide an explicit way to opt out of type-level validations

3 participants