✨Implement opaque declarative validation marker#1360
✨Implement opaque declarative validation marker#1360itzPranshul wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itzPranshul The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @itzPranshul. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
alvaroaleman
left a comment
There was a problem hiding this comment.
/ok-to-test
Can you please also add an envtest-based test?
This commit introduces , a field-level marker that suppresses type-level validation inheritance for a specific field, while still allowing field-level markers
an API server integration test to verify validation exactly kubernetes would execute it
What does this do, and why do we need it?
When a Go type has type-level validation markers, those markers are automatically inherited by all fields that use that type. This PR introduces
+k8s: opaque, a field-level marker that suppresses type-level validation inheritance for a specific field.This marker gives users a way to opt-out of type level validations when reusing a go type in a CRD struct field, so they can define custom field level validations without inheriting any conflicts.
Which issue(s) this PR is related to:
Fixes #1301