fix: make version input optional with default 'latest' #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore backward compatibility by making the version input optional with a default value of 'latest'. This fixes the breaking change introduced in b2454fb where version was made required without updating documentation or providing a default. Users who don't specify a version will now automatically use the latest kubescape release, matching the previous behavior. Signed-off-by: Ben <ben@armosec.io>
Contributor
|
fixed already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Commit b2454fb introduced a breaking change by making the
versioninput required without:This breaks all existing workflows that don't specify a version, including:
Solution
Make
versionoptional with a default of"latest"to restore backward compatibility.Changes
version: description: | The version of Kubescape to use. Can be a specific version (e.g. "v3.0.21") or "latest". - required: true + required: false + default: "latest"Behavior
version): Will now automatically use the latest kubescape releaseversion): Continue to work as expected with their specified version