Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

feat: new executor data struct#3

Open
exu wants to merge 6 commits intomainfrom
jacek/fix/custom-executor-example-update
Open

feat: new executor data struct#3
exu wants to merge 6 commits intomainfrom
jacek/fix/custom-executor-example-update

Conversation

@exu
Copy link
Contributor

@exu exu commented Feb 23, 2022

This PR...

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@exu exu requested a review from vsukhin February 23, 2022 09:22
// else we'll return error to simplify example
err = fmt.Errorf("invalid status code %d, (uri:%s)", resp.StatusCode, uri)

// TODO remove - debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably to remove

Copy link
Contributor

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants